Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some input filesystems don't implement purge #81

Merged
merged 1 commit into from
Jul 28, 2019

Conversation

halfnelson
Copy link
Contributor

If the input filesystem doesn't have purge, the current code throws.

C:\dev\nativescript\svelte-ns-testapp\node_modules\svelte-loader\lib\virtual.js:15
                        originalPurge.call(this, arguments);
                                      ^

TypeError: Cannot read property 'call' of undefined
    at Object.VirtualModulesPlugin.compiler.inputFileSystem.purge (C:\dev\nativescript\svelte-ns-testapp\node_modules\svelte-loader\lib\virtual.js:15:18)
    at Compiler.purgeInputFileSystem (C:\dev\nativescript\svelte-ns-testapp\node_modules\webpack\lib\Compiler.js:302:25)
    at compilerCallback (C:\dev\nativescript\svelte-ns-testapp\node_modules\webpack-cli\bin\cli.js:483:15)

I encountered this problem. This commit solved the problem

@benbot
Copy link

benbot commented May 26, 2019

And word as to why this hasn't been merged in yet?

Could it potentially break something?

@Conduitry Conduitry merged commit fa7ffff into sveltejs:master Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants