Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(site-2): TS in docs #8452

Merged
merged 53 commits into from
May 11, 2023
Merged

feat(site-2): TS in docs #8452

merged 53 commits into from
May 11, 2023

Conversation

PuruVJ
Copy link
Collaborator

@PuruVJ PuruVJ commented Apr 5, 2023

This adds TypeScript auto-generated code snippets and TS snippets in the docs.

Work in progress

@vercel
Copy link

vercel bot commented Apr 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-dev-2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2023 8:45am

@PuruVJ PuruVJ changed the base branch from master to sites April 5, 2023 03:41

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@@ -0,0 +1 @@
export type * from 'svelte/transition';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't these be part of .gitignore?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone else clones the project and build, it won't work for them, so we should leave them in. In future, maybe we'd wanna monkey patch a specific type just for the docs, this would be a place for it

// });
// }
// }
// }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this commented-out code about?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied code from sveltekit's typegen script. I'm still keeping em around, cuz these parts can be introduced in our site once we expose different kind of modules

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually nvm, I removed it. Can always copy it from git

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Simon H <[email protected]>
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some small NITs with svelte/action, most notably that $$_attributes shows up, but we can take of that separately. Merge once you're done with the PR (seems like you're currently working on it)

@PuruVJ
Copy link
Collaborator Author

PuruVJ commented May 11, 2023

Removed the $$_attributes thing as well.

CleanShot 2023-05-11 at 14 12 44@2x

Will merge this once the latest vercel deployment finishes

@PuruVJ
Copy link
Collaborator Author

PuruVJ commented May 11, 2023

Builds are passing! Merging

@PuruVJ PuruVJ merged commit 9bee59c into sites May 11, 2023
@PuruVJ PuruVJ deleted the feat/ts-in-docs branch May 11, 2023 08:49
@gtm-nayan gtm-nayan mentioned this pull request Jun 17, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants