-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(site-2): TS in docs #8452
feat(site-2): TS in docs #8452
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -0,0 +1 @@ | |||
export type * from 'svelte/transition'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't these be part of .gitignore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If someone else clones the project and build, it won't work for them, so we should leave them in. In future, maybe we'd wanna monkey patch a specific type just for the docs, this would be a place for it
// }); | ||
// } | ||
// } | ||
// } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this commented-out code about?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copied code from sveltekit's typegen script. I'm still keeping em around, cuz these parts can be introduced in our site once we expose different kind of modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually nvm, I removed it. Can always copy it from git
Co-authored-by: Simon H <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's some small NITs with svelte/action
, most notably that $$_attributes
shows up, but we can take of that separately. Merge once you're done with the PR (seems like you're currently working on it)
Builds are passing! Merging |
This adds TypeScript auto-generated code snippets and TS snippets in the docs.
Work in progress