[rust]: allow specifying TLS flavour to use #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasn
previously approved these changes
Apr 15, 2023
// only the default-tls cargo tree // both since features are additive cargo tree --features rustls-tls // only rustls-tls cargo tree --features rustls-tls --no-default-features closes svix#889
tasn
approved these changes
Apr 15, 2023
svix-gabriel
pushed a commit
that referenced
this pull request
Apr 18, 2023
// only the default-tls cargo tree // both since features are additive cargo tree --features rustls-tls // only rustls-tls cargo tree --features rustls-tls --no-default-features closes #889 ## Motivation Bellow is verbatim copy from issue #889 created by @msdinit We are building our application against musl, cross-compiling it from regular libc Ubuntu. However, we are having issues with svix client, because it depends on system OpenSSL, which in our case would be linked against libc. There sfackler/rust-openssl#603, but they are a bit involved. ## Solution Added cargo features allowing users to choose which ssl version to use for svix reqwest http client, keeping backwards compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
// only the default-tls
cargo tree
// both since features are additive
cargo tree --features rustls-tls
// only rustls-tls
cargo tree --features rustls-tls --no-default-features
closes #889
Motivation
Bellow is verbatim copy from issue #889 created by @msdinit
We are building our application against musl, cross-compiling it from regular libc Ubuntu. However, we are having issues with svix client, because it depends on system OpenSSL, which in our case would be linked against libc. There sfackler/rust-openssl#603, but they are a bit involved.
Solution
Added cargo features allowing users to choose which ssl version to use for svix reqwest http client, keeping backwards compatibility.