Fully resolve external $ref tree #9294
Conversation
Fully resolve references when loading OpenAPI specification. This is required to fully traverse the external $ref tags
1. Load spec as URL 2. $ref in requestBody 3. Internal $ref within referenced document throws NPE
|
Hi there. Any chance this can be merged? Is there something else I can do on this PR? Thanks! |
|
Came here because we probably also need such a fix. Fyi: But I tried skipping it and it turns out that it is not just this test that is failing. If you skip this test two more tests within the same suite fail. |
|
@jweisman any plans on resolving those failed tests? |
|
Since this PR has been open for 9 months, the upstream repository changed considerably. I will need to rebase and see why the tests are failing. |
|
@jweisman Thank you 👍 |
|
Hi @daemonfire300 . I decided to add resolveFully as an option to avoid breaking any tests or previous behavior. I opened a new PR for that- #10200. Would be grateful if you could take a look there and provide any comments. Thanks! |
Fully resolve references when loading OpenAPI specification. This is required to fully traverse the external $ref tags
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
Call
ParseOptions.setResolveFullyto fully walk the reference tree for responseBodies and schemas.