Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stack overflow with deep nested braces #10240

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Fnll
Copy link
Contributor

@Fnll Fnll commented Mar 20, 2025

Change-Id: Ib4712653008bf75c1fe008b367f1d56924d86280

Description:
I am trying to solve issue #10207. I find it not a problem with wasm but stack overflow when parsing deep nested braces. I referred to the solution in this issue #1627, which is to expand the stack size.

I am quite new to this project. Plz feel free to comment if I made it wrong.

BREAKING CHANGE:

Related issue (if exists):
nodejs/node#57471
#10207

fix: stack overflow with many nested braces

Change-Id: Ia90fd69aff3a0819cf15e44142691f5e20222e18
@Fnll Fnll requested review from a team as code owners March 20, 2025 18:00
Copy link

changeset-bot bot commented Mar 20, 2025

⚠️ No Changeset found

Latest commit: 9846857

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The maybe_grow function is noop for Wasm target

Copy link

codspeed-hq bot commented Mar 20, 2025

CodSpeed Performance Report

Merging #10240 will improve performances by 1.23%

Comparing Fnll:fix/issue-10207 (9846857) with main (69788d7)

Summary

⚡ 6 improvements
✅ 146 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
es/parser/angular 31.9 ms 31.5 ms +1%
es/parser/backbone 4.9 ms 4.9 ms +1.07%
es/parser/jquery 25.6 ms 25.3 ms +1.04%
es/parser/jquery mobile 39 ms 38.6 ms +1.04%
es/parser/mootools 20.4 ms 20.1 ms +1.06%
es/parser/yui 19.3 ms 19.1 ms +1.23%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants