Make v2 API functions and types public #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
reviewed
Sep 5, 2024
fabianfett
reviewed
Sep 5, 2024
fabianfett
reviewed
Sep 5, 2024
| @@ -136,7 +137,7 @@ package struct LambdaCodableAdapter< | |||
| } | |||
|
|
|||
| /// A ``LambdaResponseStreamWriter`` wrapper that conforms to ``LambdaResponseWriter``. | |||
| package struct LambdaCodableResponseWriter<Output, Encoder: LambdaOutputEncoder, Base: LambdaResponseStreamWriter>: | |||
| public struct LambdaCodableResponseWriter<Output, Encoder: LambdaOutputEncoder, Base: LambdaResponseStreamWriter>: | |||
There was a problem hiding this comment.
can we drop the Codable name here.
fabianfett
reviewed
Sep 5, 2024
fabianfett
reviewed
Sep 5, 2024
…ype of `LambdaContext` `getRemainingType()` to `Duration`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
As part of the implementation of the v2 API (#339), we landed new additions with the
packageaccess modifier so that they could not be mistakenly used while work was still in progress.We now want to make the new additions introduced
public.Modifications:
public.Result:
The new API can be used by adopters.