Disable test to unblock swift PR testing. #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like the order in which things are getting printed was flipped. So we are getting this error in the swift build:
20:53:48 TestFoundation/TestNSDictionary.swift:49: error: TestNSDictionary.test_description : XCTAssertEqual failed: ("{
20:53:48 foo = bar;
20:53:48 baz = qux;
20:53:48 }") is not equal to ("{
20:53:48 baz = qux;
20:53:48 foo = bar;
20:53:48 }") -
I would just fix this, but I don't work often in this codebase so I think
disabling is the right way to go.
https://bugs.swift.org/browse/SR-7166
|
@swift-ci test and merge |
|
Both of these tests were broken when swiftlang/swift#14913 landed on Swift master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the order in which things are getting printed was flipped. So we are getting this error in the swift build:
20:53:48 TestFoundation/TestNSDictionary.swift:49: error: TestNSDictionary.test_description : XCTAssertEqual failed: ("{
20:53:48 foo = bar;
20:53:48 baz = qux;
20:53:48 }") is not equal to ("{
20:53:48 baz = qux;
20:53:48 foo = bar;
20:53:48 }") -
I would just fix this, but I don't work often in this codebase so I think
disabling is the right way to go.
https://bugs.swift.org/browse/SR-7166