Adopt Swift 6 and audit for Sendable #5000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure how reviewable this is. It is the result of repeated iteration and small fixes. |
This was referenced Jul 5, 2024
jmschonfeld
reviewed
Jul 8, 2024
parkera
force-pushed
the
parkera/sendable_annotations
branch
3 times, most recently
from
0240cd7 to
c5f3634
Compare
|
@swift-ci please test |
|
@swift-ci test |
|
swiftlang/swift-foundation#742 |
|
@Azoy the linked PR only fixed the Synchronization import for |
parkera
force-pushed
the
parkera/sendable_annotations
branch
from
e04a8f8 to
203ed95
Compare
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
… in both Swift and C code
…the CF type inside the lock
parkera
force-pushed
the
parkera/sendable_annotations
branch
from
203ed95 to
5cb2337
Compare
|
@swift-ci test |
parkera
force-pushed
the
parkera/sendable_annotations
branch
from
d3e3766 to
c2bc79a
Compare
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test windows |
parkera
added a commit
to parkera/swift-corelibs-foundation
that referenced
this pull request
Jul 25, 2024
* Adopt Sendable, fix Sendable related warnings, and fix other warnings in both Swift and C code * Upgrade to Swift 6 - Fix associated warnings * Remove Sendable annotation from NSAffineTransform * Cleanup some unused types in Utilities and use a Mutex instead of NSLock * Remove some warnings for Windows builds * Add version 6 and warning flags to CMake file * Adapt to some changes in how unchecked Sendable conformance is declared * Update swift-foundation dependency * Update locking strategy for DateFormatter and NumberFormatter - keep the CF type inside the lock * Add annotations for Core and CFSocketRef * Resolve a warning in TestDecimal * Use noncopyable State type for DateFormatter and NumberFormatter * Mark DirectoryEnumerator as non-Sendable * Work around compiler crashes when using ~Copyable types * Clarify comment of _nonSendable with a message explaining the remaining warning
parkera
added a commit
that referenced
this pull request
Jul 25, 2024
* Adopt Sendable, fix Sendable related warnings, and fix other warnings in both Swift and C code * Upgrade to Swift 6 - Fix associated warnings * Remove Sendable annotation from NSAffineTransform * Cleanup some unused types in Utilities and use a Mutex instead of NSLock * Remove some warnings for Windows builds * Add version 6 and warning flags to CMake file * Adapt to some changes in how unchecked Sendable conformance is declared * Update swift-foundation dependency * Update locking strategy for DateFormatter and NumberFormatter - keep the CF type inside the lock * Add annotations for Core and CFSocketRef * Resolve a warning in TestDecimal * Use noncopyable State type for DateFormatter and NumberFormatter * Mark DirectoryEnumerator as non-Sendable * Work around compiler crashes when using ~Copyable types * Clarify comment of _nonSendable with a message explaining the remaining warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
Sendableannotation, and adds a flag to require all future types to do so as wellnoasyncfunctionsnonisolated(unsafe). This should be considered a short term workaround and not a design pattern. In the future, adding these will be disfavored and rightfully proving to the compiler that it is safe will be preferred. However, it's not practical to do all of that in one shot.Synchronizationtypes and more annotations.