Add stub for Testing module #5077
Merged
+33
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmschonfeld
requested review from
rintaro,
parkera,
grynspan,
iCharlesHu and
itingliu
|
@swift-ci please test |
|
Confirmed that the tests still pass with this change, and they also pass with the linked change so this should resolve the issue that the linked PR was originally hitting when re-ordering the swift-testing build |
grynspan
reviewed
Aug 20, 2024
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
rintaro
approved these changes
Aug 21, 2024
iCharlesHu
approved these changes
Aug 21, 2024
| import Musl | ||
| #elseif os(WASI) | ||
| import WASILibc | ||
| #elseif canImport(CRT) |
There was a problem hiding this comment.
nit I think we should might as well add #if canImport(Bionic) here as well. But def none blocking
There was a problem hiding this comment.
Fair point - I'm not sure if we've tried running SwiftPM tests on android for this repo yet so I'll follow up with that later once we try to do that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that swift-testing is present in the toolchain, SwiftPM builds of the test target in this package will automatically import
Testing, causing our test target to link theTestinglibrary in the toolchain. This is problematic, because theTestingmodule links Foundation (from the toolchain) which results in a variety of issues and crashes when running our tests caused by the presence of two Foundations (classes of the same name are indistinguishable and one implementation is nondeterministically picked leading to failures when bridging). To resolve this, we will use the same solution we found for XCTest - to vendor a small copy of the library within our project that will be picked up instead of the toolchain version. In our case, we only need a small stub because we don't actually use theTestingmodule yet.In the future, now that SwiftPM supports cycles in package dependencies as long as there is no target-level cycle, we could update the package build to use the package build of swift-testing (which we could have rely on the package build of Foundation thus ensuring only one Foundation is present) but for now this simple solution gets us building and testing again.