Fix a leak when mutating CharacterSet by moving away from _SwiftNSCharacterSet wrapper #5107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…racterSet wrapper rdar://137806932
|
@swift-ci test |
itingliu
approved these changes
Oct 15, 2024
|
Also we probably want this for 6.0.2 as well |
It was an abstraction for the several types that used this pattern. But this is the only one left, so it has outlived its usefulness. The Unmanaged part of it was an attempt to avoid accidentally increasing the retain count so copy-on-write worked correctly. |
parkera
added a commit
to parkera/swift-corelibs-foundation
that referenced
this pull request
Oct 15, 2024
…racterSet wrapper (swiftlang#5107) rdar://137806932 (cherry picked from commit cb6b2fa)
parkera
added a commit
to parkera/swift-corelibs-foundation
that referenced
this pull request
Oct 15, 2024
…racterSet wrapper (swiftlang#5107) rdar://137806932 (cherry picked from commit cb6b2fa)
parkera
added a commit
to parkera/swift-corelibs-foundation
that referenced
this pull request
Oct 22, 2024
… up to swiftlang#5107) rdar://138005684
parkera
added a commit
to parkera/swift-corelibs-foundation
that referenced
this pull request
Oct 22, 2024
… up to swiftlang#5107) rdar://138005684 (cherry picked from commit 592f015)
parkera
added a commit
to parkera/swift-corelibs-foundation
that referenced
this pull request
Oct 22, 2024
… up to swiftlang#5107) rdar://138005684 (cherry picked from commit 592f015)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CharacterSetwas the one remaining type in swift-corelibs-foundation using a wrapper type to handle moving between immutable/mutable and handling uniqueness checks. By removing the wrapper and simplifying the usage, we can also remove the leak from mismanaging an "Unmanaged" CF type reference.rdar://137806932