[Musl] Add back missing autolink arguments, fix CFPosixSpawnFileActionsChdir. #5143
Conversation
…nsChdir. We need a handful more autolink arguments; these were in a previous PR, but seem to have gone missing at some point during the re-core. Additionally, Musl has the `posix_spawn_file_actions_addchdir_np()` function rather than the non-`_np()` version. Fixes swiftlang#5089.
|
@swift-ci Please test Linux platform |
|
@swift-ci Please test Windows platform |
|
This was previously cherry-picked to |
|
Explanation: We need to add the autolink options in order for programs built with the Static SDK to work without having to add extra linker arguments. Also, Musl has the |
| @@ -57,6 +57,7 @@ set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/bin) | |||
| set(CMAKE_Swift_MODULE_DIRECTORY ${CMAKE_BINARY_DIR}/swift) | |||
|
|
|||
| option(BUILD_SHARED_LIBS "build shared libraries" ON) | |||
| option(BUILD_FULLY_STATIC "build fully static" NO) | |||
There was a problem hiding this comment.
I think that we should prefer this to be spelt FOUNDATION_FULLY_STATIC. BUILD_SHARED_LIBS is a standard CMake option that we are changing the default value for.
There was a problem hiding this comment.
If we're going to make that change, we should do so separately; this is already merged in other branches and is just a cherry pick.
There was a problem hiding this comment.
(Changing that will also require a matching change to the scripts in the swift-docker repo too.)
We need a handful more autolink arguments; these were in a previous PR, but seem to have gone missing at some point during the re-core.
Additionally, Musl has the
posix_spawn_file_actions_addchdir_np()function rather than the non-_np()version.Fixes #5089.
rdar://140914176