Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default preview server port #373

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Conversation

Kyle-Ye
Copy link
Contributor

@Kyle-Ye Kyle-Ye commented Sep 8, 2022

Bug/issue #, if applicable:

Close #371

Source: https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xhtml?search=http

Thanks @amartini51 for providing the source explanation

Summary

Update default preview server port

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Ran the ./bin/test script and it succeeded
  • Updated documentation if necessary

Sorry, something went wrong.

@Kyle-Ye Kyle-Ye requested a review from franklinsch September 8, 2022 16:26
@Kyle-Ye
Copy link
Contributor Author

Kyle-Ye commented Sep 8, 2022

@swift-ci please test

@Kyle-Ye
Copy link
Contributor Author

Kyle-Ye commented Sep 8, 2022

@swift-ci please test

@Kyle-Ye Kyle-Ye requested a review from d-ronnqvist September 9, 2022 01:22
Copy link
Contributor

@franklinsch franklinsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@Kyle-Ye
Copy link
Contributor Author

Kyle-Ye commented Sep 9, 2022

@swift-ci please test and merge

@Kyle-Ye
Copy link
Contributor Author

Kyle-Ye commented Sep 9, 2022

@swift-ci please test

@Kyle-Ye Kyle-Ye merged commit 5d00682 into swiftlang:main Sep 9, 2022
@Kyle-Ye Kyle-Ye deleted the default-port branch September 9, 2022 11:23
@Kyle-Ye Kyle-Ye mentioned this pull request Oct 4, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The default 8000 port may conflict with existing local web server ports.
2 participants