Remove severity #943
Merged
Remove severity #943
+41
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkolb
requested review from
ahoppen,
allevato,
bnbarham and
shawnhyam
as code owners
bkolb
force-pushed
the
removeWarnings
branch
4 times, most recently
from
d5307db to
6b359d8
Compare
allevato
reviewed
Feb 25, 2025
allevato
reviewed
Feb 25, 2025
allevato
reviewed
Feb 25, 2025
bkolb
force-pushed
the
removeWarnings
branch
2 times, most recently
from
382c324 to
dec91d5
Compare
allevato
reviewed
Mar 13, 2025
bkolb
force-pushed
the
removeWarnings
branch
7 times, most recently
from
476b317 to
d27a15d
Compare
|
I think I addressed all your comments. Can you please check again? |
allevato
approved these changes
Mar 18, 2025
allevato
reviewed
Mar 18, 2025
There was a problem hiding this comment.
Looks like these need to be added to api-breakages.txt:
7 breaking changes detected in SwiftFormat:
💔 API breakage: func Rule.diagnose(_:on:severity:anchor:notes:) has parameter 2 type change from SwiftFormat.Finding.Severity? to SwiftFormat.FindingAnchor
💔 API breakage: func Rule.diagnose(_:on:severity:anchor:notes:) has parameter 3 type change from SwiftFormat.FindingAnchor to [SwiftFormat.Finding.Note]
💔 API breakage: enum Finding.Severity has been removed
💔 API breakage: var Finding.severity has been removed
💔 API breakage: var FindingCategorizing.defaultSeverity has been removed
💔 API breakage: var FindingCategorizing.defaultSeverity has been removed
💔 API breakage: func Rule.diagnose(_:on:severity:anchor:notes:) has been renamed to func diagnose(_:on:anchor:notes:)
Instead of making the severity configurable, this patch removes severity all together and treats every finding as an error. Issue: swiftlang#879
|
I updated the api-breakages.txt file. Can you please approve the workflow again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of making the severity configurable,
this patch removes severity all together and treats every finding as an error.
Issue: #879