Use lstat() semantics for URL directory detection #1204
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically,
NS/URL
checks if a path is a directory usinggetattrlist
withFSOPT_NOFOLLOW
. This is equivalent tolstat()
in the sense that it won't follow a symlink at the end of the path, and it will report information about the symlink itself.In the Swift
URL
implementation, I called intoFileManager
to check if a path is a directory, butFileManager
usesstat()
for this purpose (and historically always has).Since
URL
historically doesn't follow a symlink at the end of the path, this PR switches to usinglstat()
on UNIX-like platforms instead of calling intoFileManager
.On Windows, we can create the file handle with
FILE_FLAG_OPEN_REPARSE_POINT
and check for the flag to achieve the same semantics.