Autolink wasi-libc emulation libraries #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`_WASI_EMULATED_XXX` macros require linking against the corresponding emulation libraries. This patch adds `-Xfrontend -public-autolink-library` flags to the Swift compiler invocation to automatically link against the emulation libraries. Also enable getpid emulation explicitly, as it is available by default but emiting a warning.
|
@swift-ci test |
33 tasks
jmschonfeld
reviewed
Aug 12, 2024
|
@swift-ci test |
jmschonfeld
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
This looks ok to me - since this makes some nontrivial changes to the CMake files and we don't have CI for that on this repo yet, could you kick off a cross-repo toolchain test run on a swift PR linked to this change so that we can validate this doesn't somehow inadvertently break the existing CMake build? After that passes we can go ahead and merge this
|
Looks like the linked toolchain build passed. Thanks! |
cthielen
pushed a commit
to cthielen/swift-foundation
that referenced
this pull request
Nov 8, 2024
* Autolink wasi-libc emulation libraries `_WASI_EMULATED_XXX` macros require linking against the corresponding emulation libraries. This patch adds `-Xfrontend -public-autolink-library` flags to the Swift compiler invocation to automatically link against the emulation libraries. Also enable getpid emulation explicitly, as it is available by default but emiting a warning. * Link emulation libraries directly if building shared libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_WASI_EMULATED_XXXmacros require linking against the corresponding emulation libraries. This patch adds-Xfrontend -public-autolink-libraryflags to the Swift compiler invocation to automatically link against the emulation libraries. Also enable getpid emulation explicitly, as it is available by default but emiting a warning.