Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update swift-async-algorithms to 1.0.0-beta.1 #44

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Update swift-async-algorithms to 1.0.0-beta.1 #44

merged 3 commits into from
Nov 10, 2023

Conversation

MaxDesiatov
Copy link
Contributor

The new release contained a breaking change renaming throttle to _throttle.

@MaxDesiatov MaxDesiatov added the dependencies Changes to dependencies label Nov 8, 2023
@MaxDesiatov MaxDesiatov requested a review from euanh November 8, 2023 16:45
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

1 similar comment
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@euanh
Copy link
Contributor

euanh commented Nov 9, 2023

The _throttle change came in apple/swift-async-algorithms#296. The discussion there suggests we should watch out for the semantics possibly changing in a future release.

@euanh
Copy link
Contributor

euanh commented Nov 9, 2023

Dependency resolution problem on swift-main:

debug: [DependencyResolver] 'swift-log[everything] 1.5.3..<2.0.0' is satisfied by '[Derivation: swift-log[everything] 1.5.3..<2.0.0 ← {code[everything] 1.0.0, ¬swift-log[everything] 1.5.3..<2.0.0}]', which is caused by '{code[everything] 1.0.0, ¬swift-log[everything] 1.5.3..<2.0.0}'. new incompatibility: '{code[everything] 1.0.0}'
debug: [DependencyResolver] failed to resolve '{code[everything] 1.0.0}'
error: Dependencies could not be resolved because no versions of 'swift-log' match the requirement 1.5.3..<2.0.0 and root depends on 'swift-log' 1.5.3..<2.0.0.

@MaxDesiatov MaxDesiatov self-assigned this Nov 9, 2023
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov MaxDesiatov enabled auto-merge (squash) November 10, 2023 18:47
@MaxDesiatov MaxDesiatov merged commit 8633cbc into main Nov 10, 2023
@MaxDesiatov MaxDesiatov deleted the maxd/update-async-algorithms branch November 10, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@euanh euanh euanh approved these changes

Assignees

@MaxDesiatov MaxDesiatov

Labels
dependencies Changes to dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxDesiatov @euanh