Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.1][Compat] Add GenericArgumentSyntax compatibility initializer #2921

Merged
merged 1 commit into from
Dec 17, 2024
Merged

[6.1][Compat] Add GenericArgumentSyntax compatibility initializer #2921

merged 1 commit into from
Dec 17, 2024

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Dec 16, 2024 •
edited
Loading

Cherry-pick #2920 into release/6.1

  • Explanation: Parse integer generics #2859 changed the argument parameter from some TypeSyntaxProtocol to GenericArgumentSyntax.Argument. Add back the old initializer to keep the source compatibility.
  • Scope: Syntax node initialization
  • Risk: Low. Just adding a "disfavored" initializer overload
  • Testing: Passes current test suite
  • Issues: rdar://141562966
  • Reviewer: TBA

@rintaro
Copy link
Member Author

rintaro commented Dec 16, 2024

@swift-ci Please test

@rintaro rintaro enabled auto-merge December 16, 2024 23:40
@rintaro
Copy link
Member Author

rintaro commented Dec 17, 2024

@swift-ci Please test Windows

@rintaro rintaro merged commit 8ceb172 into swiftlang:release/6.1 Dec 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

@ahoppen ahoppen Awaiting requested review from ahoppen ahoppen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rintaro @bnbarham