Configure CMake rules to install content into toolchain #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmontgomery
added
enhancement
|
@swift-ci please test |
grynspan
reviewed
Jul 10, 2024
| @@ -97,7 +97,8 @@ target_link_libraries(Testing PRIVATE | |||
| add_dependencies(Testing | |||
| TestingMacros) | |||
| target_compile_options(Testing PRIVATE | |||
| -enable-library-evolution) | |||
| -enable-library-evolution | |||
| -emit-module-interface -emit-module-interface-path $<TARGET_PROPERTY:Testing,Swift_MODULE_DIRECTORY>/Testing.swiftinterface) | |||
There was a problem hiding this comment.
Would it be possible for us to emit our private interface too, so that developers could use @_spi symbols?
|
Note this PR is still a draft, I have TODO comments I know I still need to resolve |
compnerd
reviewed
Jul 10, 2024
Sources/TestingMacros/CMakeLists.txt
Outdated
| # This is not the plugin's actual, final install location -- it's only | ||
| # relative to this external project's install dir. The final location is | ||
| # determined by the "outer" project. | ||
| install(TARGETS TestingMacros DESTINATION "") |
There was a problem hiding this comment.
Can you leave off the DESTINATION ""?
stmontgomery
force-pushed
the
toolchain
branch
2 times, most recently
from
4dbafac to
b14866c
Compare
grynspan
reviewed
Jul 12, 2024
Sources/TestingMacros/Support/Additions/FunctionDeclSyntaxAdditions.swift
Outdated
Show resolved
Hide resolved
stmontgomery
force-pushed
the
toolchain
branch
2 times, most recently
from
c1da06f to
2e882c6
Compare
2 tasks
|
Closing as this PR has been superseded by #581. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes several changes to the CMake rules to support installing built content into a toolchain.
Motivation:
This is necessary to support including swift-testing in Swift 6 toolchains.
Checklist: