Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage of CustomTestStringConvertible.swift. #628

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Improve test coverage of CustomTestStringConvertible.swift. #628

merged 1 commit into from
Aug 21, 2024

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Aug 21, 2024 •
edited
Loading

This PR adds 100% test coverage to CustomTestStringConvertible.swift.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan
Improve test coverage of CustomTestStringConvertible.swift.
7acff1b 
This PR adds 100% test coverage to CustomTestStringConvertible.swift.
@grynspan grynspan added the enhancement New feature or request label Aug 21, 2024
@grynspan grynspan self-assigned this Aug 21, 2024
@grynspan
Copy link
Contributor Author

@swift-ci test

suzannaratcliff
suzannaratcliff approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@suzannaratcliff suzannaratcliff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks great!

@grynspan grynspan merged commit 2e3ed1f into main-next Aug 21, 2024
3 checks passed
@grynspan grynspan deleted the jgrynspan/customteststringconvertible-test-coverage branch August 21, 2024 18:23
@grynspan grynspan added this to the Swift 6.1 milestone Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suzannaratcliff suzannaratcliff suzannaratcliff approved these changes

@stmontgomery stmontgomery Awaiting requested review from stmontgomery

@dennisweissmann dennisweissmann Awaiting requested review from dennisweissmann

@briancroom briancroom Awaiting requested review from briancroom

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski

Assignees

@grynspan grynspan

Labels
enhancement New feature or request
Projects
None yet
Milestone
Swift 6.1
Development

Successfully merging this pull request may close these issues.
2 participants
@grynspan @suzannaratcliff