Expose the target triple as a separate string from the testing library version. #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
added
enhancement
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
grynspan
force-pushed
the
jgrynspan/target-triple
branch
from
d13d520 to
3231f37
Compare
|
@swift-ci test |
|
@swift-ci test |
|
@kateinoigakukun FYI some WASI-specific tweaks here. |
stmontgomery
reviewed
Sep 9, 2024
stmontgomery
approved these changes
Sep 9, 2024
kateinoigakukun
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a script to our CMake build to capture the target triple being used to build Swift Testing so that we can include it in our diagnostic output.
Apple's fork of Swift Testing (as included with Xcode 16) also includes this information, and it is very useful to have when reviewing bug reports as it can tell us if a problem is specific to a given architecture or OS variant.
Checklist: