Special-case FileHandle(forWritingAtPath: "CONOUT$") on Windows.
#654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR special-cases calls to `FileHandle.init(forWritingAtPath:)` when passed `"CONOUT$"` (the reserved "console output" file) on Windows such that it does not open a new file but just returns a copy of `.stdout` instead. This change is necessary because, on Windows, opening and locking `"CONOUT$"` does not lock `stdout` (they're considered entirely different files) and output written to `"CONOUT$"` is wrapped at the console's column limit even though it's being written as binary data. The VSCode Swift plugin authors would like to be able to specify writing the JSON event stream to `"CONOUT$"`, but the observed behaviour is stopping them from doing so.
grynspan
added
bug
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
|
LOL, got to love Windows. Nice catch! |
plemarquand
approved these changes
Aug 30, 2024
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR special-cases calls to
FileHandle.init(forWritingAtPath:)when passed"CONOUT$"(the reserved "console output" file) on Windows such that it does not open a new file but just returns a copy of.stdoutinstead.This change is necessary because, on Windows, opening and locking
"CONOUT$"does not lockstdout(they're considered entirely different files) and output written to"CONOUT$"is wrapped at the console's column limit even though it's being written as binary data. The VSCode Swift plugin authors would like to be able to specify writing the JSON event stream to"CONOUT$", but the observed behaviour is stopping them from doing so.Checklist: