Replace rethrows with typed throws in Graph #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmontgomery
added
enhancement
stmontgomery
requested review from
grynspan,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci please test |
suzannaratcliff
approved these changes
Sep 4, 2024
|
@swift-ci please test |
|
Let's double-check that this is back-deployable to older Apple OSes. Otherwise, ✅ |
grynspan
approved these changes
Sep 5, 2024
|
I've gotten confirmation offline that the typed throws is back-deployable. |
|
@swift-ci please test |
stmontgomery
pushed a commit
that referenced
this pull request
Sep 11, 2024
Reverts #662 This change is likely the culprit for crashes on the CI bot: [Swift Incremental RA - macOS - Apple Silicon](https://ci.swift.org/job/oss-swift-incremental-RA-macos-apple-silicon/)
2 tasks
stmontgomery
added a commit
that referenced
this pull request
Sep 16, 2024
This un-reverts the changes originally landed in #662. Those changes were reverted in #679 due to a compiler issue which broke CI builds. We believe that compiler issue has been resolved via a revert in the Swift repo, made in swiftlang/swift#76435. Before landing this (currently draft) PR, I plan to validate that Swift's CI is no longer affected using a cross-repo CI toolchain build. ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces usage of
rethrowswith typed throws in the internal-onlyGraphsupport type.Motivation:
It's now recommended to use typed throws in generic code that never produces its own errors, but only passes through errors that come from callers. And adopting typed throws in more places will reduce barriers to eventually supporting Embedded Swift.
Modifications:
rethrowswith the analogous typed throws declaration inGraph.Result:
No behavioral/runtime change.
Checklist: