Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stdlib] Arrays: Include the count as a discriminator value #16030

Merged
merged 1 commit into from
Apr 19, 2018

Conversation

lorentey
Copy link
Member

This makes the hash encoding unambiguous when arrays are hashed in sequence.

@lorentey
Copy link
Member Author

(This is change no. 3 in a series of PRs spawned from #15939)

@lorentey lorentey force-pushed the array-hash-encoding branch from e23a826 to ca83d3d Compare April 19, 2018 17:33
@lorentey
Copy link
Member Author

cc @lancep; the new tests don't catch this issue yet, but they will once I land my checkHashable improvements.

@lorentey lorentey requested a review from lancep April 19, 2018 17:35
@lorentey
Copy link
Member Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - e23a8262a86f286865ff5fc7b28200c080edcf53

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - e23a8262a86f286865ff5fc7b28200c080edcf53

This makes the hash encoding unambiguous when arrays are hashed in sequence.
@lorentey lorentey force-pushed the array-hash-encoding branch from ca83d3d to 882462f Compare April 19, 2018 19:05
@lorentey
Copy link
Member Author

@swift-ci please test and merge

Copy link
Contributor

@lancep lancep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lorentey
Copy link
Member Author

@swift-ci please test and merge

@swift-ci swift-ci merged commit f45a9c8 into swiftlang:master Apr 19, 2018
@lorentey lorentey deleted the array-hash-encoding branch April 30, 2018 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants