Sema: Gut synthesizeMemberForLookup() #16054
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
gut-synthesize-member-for-lookup
branch
2 times, most recently
from
43f77de to
baa01da
Compare
|
@swift-ci Please smoke test |
slavapestov
force-pushed
the
gut-synthesize-member-for-lookup
branch
from
baa01da to
b2d0124
Compare
|
@swift-ci Please test source compatibility |
|
@swift-ci Please test |
|
Build failed |
itaiferber
approved these changes
Apr 20, 2018
… checking This is a more elegant path to ensuring that init(from:) and encode(to:) get synthesized than synthesizeMemberForLookup().
…irements Since init(from:) and encode(to:) are protocol requirements, any name lookup of them will find the protocol requirement, and if the witness is not present we will synthesize it on the spot. Only CodingKeys requires special handling here, since it is not a protocol requirement, but has to get synthesized anyway.
slavapestov
force-pushed
the
gut-synthesize-member-for-lookup
branch
from
b2d0124 to
d8b4d99
Compare
|
Thanks for taking a look! As you’ve noticed this cleanup caused a test failure. I merged the other fixes though since they don’t depend on this, they should all be in swift-4.2-branch now. I’ll revisit this PR later. |
xedin
approved these changes
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More cleanups based off of #16053.