Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2][benchmark] Replace hashValue implementations with hash(into:) #16303

Conversation

lorentey
Copy link
Member

@lorentey lorentey commented May 2, 2018

This gives us a better picture of expected hashing performance.

Add a new benchmark to track legacy hashValue performance.

Reviewed by @airspeedswift in #16157

This gives us a better picture of expected hashing performance.

Add a new benchmark to track legacy hashValue performance.

(cherry picked from commit ec91f6b)
@lorentey
Copy link
Member Author

lorentey commented May 2, 2018

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented May 2, 2018

Build failed
Swift Test Linux Platform
Git Sha - ebb9c67

@lorentey
Copy link
Member Author

lorentey commented May 2, 2018

@swift-ci please clean test linux platform

@lorentey lorentey merged commit a952cf0 into swiftlang:swift-4.2-branch May 18, 2018
@lorentey lorentey deleted the modernize-hashing-in-benchmarks-4.2 branch May 18, 2018 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants