[AutoDiff] Skip implicit GenericTypeParamDecl AST verification.
#32343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The differentiation transform creates implicit auxiliary struct and enum declarations, cloning implicit `GenericTypeParamDecl`s from a generic signature into a flat `GenericParamList`. These `GenericTypeParamDecl`s may fail depth verification based on `DC->getGenericContextDepth()` because the auxiliary struct and enum declarations are always flat. Skipping verification for implicit `GenericTypeParamDecl`s created by the differentiation transform is the easiest way to fix errors. No other code paths create implicit `GenericTypeParamDecl`s. An alternative is to make the differentiation transform properly generated nested struct and enum declarations. This should fix verification but bloats the number of generated declarations.
|
@swift-ci Please test tensorflow |
compnerd
approved these changes
Jun 12, 2020
|
Hi, is it possible to merge this into the main branch? Without this patch recent attempt to use _Differentiation from a stock tool chain in a debug build fail, and again trigger "GenericTypeParamDecl has incorrect depth". A minimal reproducer is here: https://github.com/astrotuna201/ASTVerifierReproducer.git |
rxwei
pushed a commit
that referenced
this pull request
Aug 17, 2021
…cl AST verification failure. (#38745) Provides reproducer lit test case for AutoDiff implicit auxiliary struct and enum declarations that clone implicit GenericTypeParamDecls from a generic signature into a flat GenericParamList, and lead to a compiler assert about GenericTypeParamDecl depth during merge module operation. Related to #32343.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The differentiation transform creates implicit auxiliary struct and enum
declarations, cloning implicit
GenericTypeParamDecls from a genericsignature into a flat
GenericParamList.These
GenericTypeParamDecls may fail depth verification based onDC->getGenericContextDepth()because the auxiliary struct and enumdeclarations are always flat.
Skipping verification for implicit
GenericTypeParamDecls created by thedifferentiation transform is the easiest way to fix errors. No other
code paths create implicit
GenericTypeParamDecls.An alternative is to make the differentiation transform properly generated
nested struct and enum declarations. This should fix verification but
bloats the number of generated declarations.
Locally confirmed to fix
tensorflow/swift-apiscompilation with assertions.Relevant Azure CI failure:
Todos:
REQUIRES: assertsreproducer and add a unit test.master, requesting review from code owners.GenericTypeParamDeclAST verification was recently touched.