[wasm] Add shims for aliased errno constants in WASILibc overlay #75671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We provide shims for errno constants in WASILibc overlay since wasi-libc's errno.h defines those constants in a way that cannot be imported by ClangImporter. However, some errno constants are aliased in wasi-libc, and we didn't provided shims for them. This patch adds those missing shims.
|
@swift-ci test WebAssembly |
|
@swift-ci smoke test |
This was referenced Aug 3, 2024
Use
POSIXErrorCode instead of direct errno E constants from wasi-libc
swiftlang/swift-foundation#811
Closed
|
@swift-ci test WebAssembly |
kateinoigakukun
requested review from
MaxDesiatov
and removed request for
a team
MaxDesiatov
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We provide shims for errno constants in WASILibc overlay since wasi-libc's errno.h defines those constants in a way that cannot be imported by ClangImporter.
However, some errno constants are aliased in wasi-libc, and we didn't provided shims for them. This patch adds those missing shims.