[wasm] Fix ambiguous errno error when importing WASILibc module
#75747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an ambiguous `errno` error when importing WASILibc module and SwiftWASILibc Clang module. The error is caused by the fact that we define a shim for `errno` in `Platform.swift` file, but wasi-libc defines `errno` in a way ClangImporter can understand. We don't need to define shims for it, otherwise we get two candidates for `errno` identifier.
|
@swift-ci smoke test |
|
@swift-ci test WebAssembly |
33 tasks
MaxDesiatov
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an ambiguous
errnoerror when importing WASILibc module and SwiftWASILibc Clang module.The error is caused by the fact that we define a shim for
errnoinPlatform.swiftfile, but wasi-libc defineserrnoin a way ClangImporter can understand. We don't need to define shims for it, otherwise we get two candidates forerrnoidentifier.