[cxx-interop] Fix transforming spans that are not behind type aliases #79951
+44
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xazax-hun
requested review from
zoecarver,
hyp,
egorzhdan,
j-hui,
fahadnayyar,
beccadax and
ian-twilightcoder
as code owners
While we expect our users to use type aliases for template instantiations, there are some contexts when we import instantiations without aliases. Unfortunately, in case of C++ span we generated a name for the instantiation that cannot be a syntactically valid Swift type due to unary negation appearing in the type name. This PR replaces the unary negation with "Neg" in the type name and also fixed a bug that ended up printing certain unsigned values as signed. Moreover, this PR also fixes some other fallouts in the SwiftifyImport macro. rdar://146833480
Xazax-hun
force-pushed
the
gaborh/non-type-alias-span
branch
from
8aa48c5 to
af4f594
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we expect our users to use type aliases for template instantiations, there are some contexts when we import instantiations without aliases. Unfortunately, in case of C++ span we generated a name for the instantiation that cannot be a syntactically valid Swift type due to unary negation appearing in the type name. This PR replaces the unary negation with "Neg" in the type name and also fixed a bug that ended up printing certain unsigned values as signed. Moreover, this PR also fixes some other fallouts in the SwiftifyImport macro.
rdar://146833480