WIP feat(ngm): added npm-submodule build process #2
Conversation
| "webpack" | ||
| ], | ||
| "typeRoots": [ | ||
| "../node_modules/@types" |
There was a problem hiding this comment.
Why does it need to do this?
There was a problem hiding this comment.
In order to replace tsd with @types was added typeRoots
microsoft/TypeScript#9184
to simplify declarations resolution
| "compileOnSave": false, | ||
| "buildOnSave": false, | ||
| "awesomeTypescriptLoaderOptions": { | ||
| "forkChecker": true, |
There was a problem hiding this comment.
Does fork checker work for you? It never seems to actually update for me.
| @@ -7,7 +7,7 @@ import { DblClickCopyDirective } from './directives'; | |||
| import { PipesModule } from './pipes'; | |||
|
|
|||
| import { | |||
| CalendarModule, CodemirrorModule, CodeHighlightModule, | |||
| CalendarModule, /*CodemirrorModule,*/ CodeHighlightModule, | |||
There was a problem hiding this comment.
We can help code mirror to became AoT compatible too ;)
and than uncomment
| @@ -22,7 +22,125 @@ const DATE_TIME_VALUE_ACCESSOR = { | |||
| @Component({ | |||
| selector: 'swui-date-time', | |||
| providers: [DATE_TIME_VALUE_ACCESSOR], | |||
| template | |||
| template: `<div class="swui-date-time"> | |||
There was a problem hiding this comment.
Why did you bring this inline?
There was a problem hiding this comment.
@angular/compiler-cli doesn't understand html imports and can not analyze them staticaly
There was a problem hiding this comment.
ugh ... I suppose thats why they have that custom dealie in the component defs :(
|
closing for now. |
No description provided.