Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import symfony/intl polyfills #310

Merged
merged 194 commits into from
Nov 3, 2020
Merged

Import symfony/intl polyfills #310

merged 194 commits into from
Nov 3, 2020

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Oct 31, 2020 •
edited
Loading

Fixes symfony/symfony#37758

This is currently blocked by NumberFormatter, which uses the Currencies to read currency data.

TODO:

  • update the namespace
  • move tests to the tests/ folder of symfony/polyfill

webmozart and others added 30 commits April 5, 2013 10:11
@webmozart
[Intl] Refactored Locale component into two new components Icu and Intl
dc4b2df
@pborreli @webmozart
Fixed PHPDoc
c29763e
@webmozart
[Intl] Removed method IntlTestCase::skipIfInsufficientIcuVersion()
067dcd9
@webmozart
[Intl] Made the $locale parameter optional in the bundle interfaces
1f37e34
@webmozart
[Intl] Bumped the stub version to 50.1.2
296b493
@webmozart
[Intl] Only the StubNumberFormatterTest requires stub data
1bb1cff
@webmozart
[Intl] Simplified tests
ec388a2
@webmozart
[Intl] Removed ICU version comparisons from the tests
a93c0a3
@webmozart
[Intl] Moved stub data to Icu component 1.0.x
59e153b
@webmozart
[Intl] Improved inline documentation
55f3177
@webmozart
[Intl] Removed "Stub" prefix from stub classes
eeda27a
@pborreli @nicolas-grekas
Fixed typos
28dafe4
@jakzal @nicolas-grekas
[Intl] Fixed the class namespaces in the @Covers annotations.
0858e36
@jakzal @nicolas-grekas
[Intl] Fixed tests failing on PHP 5.5
b043c6b
@fabpot @nicolas-grekas
fixed CS
b2a1593
@webmozart @nicolas-grekas
[Intl] Updated stubs to reflect ICU 51.2
437f93d
@webmozart @nicolas-grekas
[Locale] Fixed: Locale::setDefault() throws no exception when "en" is…
9d9bbbf 
… passed

Conflicts:
	src/Symfony/Component/Locale/Stub/StubLocale.php
	src/Symfony/Component/Locale/Tests/Stub/StubLocaleTest.php
@fabpot @nicolas-grekas
Merge branch '2.2' into 2.3
b847ee4 
* 2.2:
  [Locale] added support for the position argument to NumberFormatter::parse()
  [Locale] added some more stubs for the number formatter
  [Yaml] fixed typo
  [Yaml] fixed a test on PHP < 5.4
  [DomCrawler]Crawler guess charset from html
  fixed PHP 5.3 compatibility
  [Yaml] reverted previous merge partially (refs #8897)
  [Security] remove unused logger
  [Security] fix typo
  [Yaml] Fixed filename in the ParseException message

Conflicts:
	src/Symfony/Component/Console/Input/InputDefinition.php
	src/Symfony/Component/Locale/Stub/StubNumberFormatter.php
	src/Symfony/Component/Locale/Tests/Stub/StubNumberFormatterTest.php
@andremaha @nicolas-grekas
[Intl] fixed datetime test as described in #9455
a6c109e
@fabpot @nicolas-grekas
fixed CS
036ffbb
@fabpot @nicolas-grekas
fixed various typos
e4b16ca
@fabpot @nicolas-grekas
fixed CS for lambdas
4e04129
@pamil @nicolas-grekas
[Intl] Added round support for ROUND_CEILING, ROUND_FLOOR, ROUND_DOWN…
954e201 
…, ROUND_UP
@pamil @nicolas-grekas
Skips test that need full lib-intl.
37a3181
@fabpot @nicolas-grekas
removed unneeded use statements
fb72797
@cordoval @nicolas-grekas
update year on licenses
c215d64
@dave1010 @nicolas-grekas
Fix for a couple of undefined classes in docblocks
b1ed95c
@fabpot @nicolas-grekas
fixed various inconsistencies
8ec74c6
@fabpot @nicolas-grekas
fixed float comparison in unit tests for HHVM
06324eb
@fabpot @nicolas-grekas
made types consistent with those defined in Hack
ac5932a
fabpot and others added 16 commits October 31, 2020 18:32
@fabpot @nicolas-grekas
Fix CS
8206136
@oleg-andreyev @nicolas-grekas
Updated ICU urls
fa6d089
@fabpot @nicolas-grekas
Add missing dots at the end of exception messages
1c48407
@fabpot @nicolas-grekas
Fix quotes in exception messages
10fbb86
@fabpot @nicolas-grekas
Fix more quotes in exception messages
c4e2d66
@Tobion @nicolas-grekas
add missing gitattributes for phpunit-bridge
bbe7c97
@derrabus @nicolas-grekas
[Intl] Fix call to ReflectionProperty::getValue() for static properties.
c10c582
@xabbuh @nicolas-grekas
use expectWarning() when possible
7060288
@fabpot @nicolas-grekas
Fix CS
b32e82c
@nicolas-grekas
Enable "native_constant_invocation" CS rule
6275224
@derrabus @nicolas-grekas
[Intl] Skip test cases that produce a TypeError on php 8.
7e14958
@xabbuh @nicolas-grekas
[Intl] promote warnings to value errors on PHP 8
364e3e3
@fabpot @nicolas-grekas
Fix CS
f958f16
@nicolas-grekas
fix rebase
b8b13af
@nicolas-grekas
Prepare for importing symfony/intl polyfills
11b6e56
@nicolas-grekas
Add 'src/Intl/Icu/' from commit 'b8b13afaf7997918a396c5404493e30d2539…
e701bd3 
…f015'

git-subtree-dir: src/Intl/Icu
git-subtree-mainline: 11b6e56
git-subtree-split: b8b13af
@nicolas-grekas nicolas-grekas mentioned this pull request Oct 31, 2020
Closed
@nicolas-grekas
Copy link
Member Author

Except for a few red tests on appveyor, this PR is green.
Only the last commit should be reviewed as all the other ones are extracted from the git history of symfony/intl

/cc @stof et al.

stof
stof reviewed Nov 3, 2020
View reviewed changes
@nicolas-grekas nicolas-grekas mentioned this pull request Nov 3, 2020
Merged
@nicolas-grekas
Copy link
Member Author

appveyor is now green, PR ready.

nicolas-grekas added a commit to symfony/symfony that referenced this pull request Nov 3, 2020
@nicolas-grekas
bug #38971 [PhpUnitBridge] fix replaying skipped tests (nicolas-grekas)
703497d 
This PR was merged into the 4.4 branch.

Discussion
----------

[PhpUnitBridge] fix replaying skipped tests

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Spotted while working on symfony/polyfill#310

See also https://3v4l.org/D6Gro for the newly skipped tests in symfony/intl

Commits
-------

849d1b3 [PhpUnitBridge] fix replaying skipped tests
symfony-splitter pushed a commit to symfony/phpunit-bridge that referenced this pull request Nov 3, 2020
@nicolas-grekas
bug #38971 [PhpUnitBridge] fix replaying skipped tests (nicolas-grekas)
b94cb85 
This PR was merged into the 4.4 branch.

Discussion
----------

[PhpUnitBridge] fix replaying skipped tests

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Spotted while working on symfony/polyfill#310

See also https://3v4l.org/D6Gro for the newly skipped tests in symfony/intl

Commits
-------

849d1b3845 [PhpUnitBridge] fix replaying skipped tests
symfony-splitter pushed a commit to symfony/intl that referenced this pull request Nov 3, 2020
@nicolas-grekas
bug #38971 [PhpUnitBridge] fix replaying skipped tests (nicolas-grekas)
193aef2 
This PR was merged into the 4.4 branch.

Discussion
----------

[PhpUnitBridge] fix replaying skipped tests

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Spotted while working on symfony/polyfill#310

See also https://3v4l.org/D6Gro for the newly skipped tests in symfony/intl

Commits
-------

849d1b3845 [PhpUnitBridge] fix replaying skipped tests
@nicolas-grekas nicolas-grekas merged commit e8107cc into symfony:main Nov 3, 2020
@nicolas-grekas nicolas-grekas deleted the import-intl branch November 3, 2020 13:26
@nicolas-grekas nicolas-grekas mentioned this pull request Nov 3, 2020
Merged
nicolas-grekas added a commit to symfony/symfony that referenced this pull request Nov 11, 2020
@nicolas-grekas
feature #38974 [Intl] deprecate polyfills in favor of symfony/polyfil…
7e3855d 
…l-intl-icu (nicolas-grekas)

This PR was merged into the 5.x branch.

Discussion
----------

[Intl] deprecate polyfills in favor of symfony/polyfill-intl-icu

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | no
| Deprecations? | yes
| Tickets       | Fix #37758
| License       | MIT
| Doc PR        | -

Follows symfony/polyfill#310
/cc @stof

Commits
-------

6ad0169 [Intl] deprecate polyfills in favor of symfony/polyfill-intl-icu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC] Split the Intl polyfill from the Intl CLDR features