Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for wrong type passed to moveTo() #103

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Fix for wrong type passed to moveTo() #103

merged 1 commit into from
Nov 16, 2021

Conversation

lemon-juice
Copy link

Issue #102

@derrabus
Copy link
Member

Can you write a test to make sure this functionality won't break again?

@lemon-juice
Copy link
Author

I'm sorry but I don't have much experience with writing tests. I might have a go at it but I would need some time to research the topic and experiment. If you need it now then it would be better to delegate it to someone else.

derrabus
derrabus approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. Thank you very much for analysing and fixing the bug.

@derrabus
Copy link
Member

Thank you @lemon-juice.

@derrabus derrabus merged commit 316f5cb into symfony:main Nov 16, 2021
@lemon-juice lemon-juice deleted the uploads branch November 17, 2021 08:50
@lemon-juice
Copy link
Author

OK, I'm glad to see it integrated quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas approved these changes

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lemon-juice @derrabus @dunglas