Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump psr/http-message version #113

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Bump psr/http-message version #113

merged 1 commit into from
Apr 21, 2023

Conversation

erikn69
Copy link

@erikn69 erikn69 commented Apr 18, 2023

Closes #112

Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot test with v2 yet because nyholm/psr7 is not ready. That shouldn't take too long, let's wait.

@stayallive
Copy link

https://github.com/Nyholm/psr7/releases/tag/1.7.0 just released, should unblock this 🥳

@derrabus derrabus closed this Apr 20, 2023
@derrabus derrabus reopened this Apr 20, 2023
@derrabus
Copy link
Member

Good news: We are indeed unblocked. The bad news: the tests blew up. 😏

@stof
Copy link
Member

stof commented Apr 20, 2023

Well, fixture classes need to be compatible with the new version of packages.

@stof
Copy link
Member

stof commented Apr 20, 2023

Note that this will probably make it hard to keep compat with PHP 7.1 in the testsuite (as variance in PHP requires PHP 7.2 and variance is require to write code supporting multiple versions of the interface).
I suggest that we bump the min version to 7.2.5 (like Symfony 5.4 LTS) instead of trying to maintain multiple fixture classes to keep the existing ones for 7.1.

@derrabus
Copy link
Member

Agreed. Let's drop Symfony 4 along with PHP 7.1: #114

@derrabus
Copy link
Member

derrabus commented Apr 20, 2023

Do we need those fixtures anyway? I mean, we could just use the classes from nyholm/psr7. 🤔

@erikn69 erikn69 force-pushed the patch-1 branch 7 times, most recently from 2703f48 to 081e078 Compare April 20, 2023 14:29
@nicolas-grekas
Copy link
Member

@erikn69 in case this helps, you can run tests locally using ./vendor/bin/simple-phpunit

@erikn69 erikn69 force-pushed the patch-1 branch 2 times, most recently from 531815e to d37db76 Compare April 20, 2023 14:40
@erikn69
Copy link
Author

erikn69 commented Apr 20, 2023

I did try ./vendor/bin/simple-phpunit, but it brings me Phpunit 9, and seems like this need Phpunit 8

@derrabus
Copy link
Member

@erikn69
Copy link
Author

erikn69 commented Apr 20, 2023

The tests run perfectly fine on PHPUnit 9

yes, it was a problem in my environment, fixed

@derrabus
Copy link
Member

Thank you @erikn69.

@derrabus derrabus merged commit 8a5748d into symfony:main Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

psr/http-message ^2.0 support?
6 participants