-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump psr/http-message version #113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot test with v2 yet because nyholm/psr7 is not ready. That shouldn't take too long, let's wait.
https://github.com/Nyholm/psr7/releases/tag/1.7.0 just released, should unblock this 🥳 |
Good news: We are indeed unblocked. The bad news: the tests blew up. 😏 |
Well, fixture classes need to be compatible with the new version of packages. |
Note that this will probably make it hard to keep compat with PHP 7.1 in the testsuite (as variance in PHP requires PHP 7.2 and variance is require to write code supporting multiple versions of the interface). |
Agreed. Let's drop Symfony 4 along with PHP 7.1: #114 |
Do we need those fixtures anyway? I mean, we could just use the classes from |
2703f48
to
081e078
Compare
@erikn69 in case this helps, you can run tests locally using |
531815e
to
d37db76
Compare
I did try |
The tests run perfectly fine on PHPUnit 9: https://github.com/symfony/psr-http-message-bridge/actions/runs/4754853299/jobs/8448204579#step:6:11 |
yes, it was a problem in my environment, fixed |
Thank you @erikn69. |
Closes #112