[Translation] Fix TranslationNodeVisitor with constant domain
#53357
Conversation
VincentLanglet
force-pushed
the
translation-twig-visitor
branch
from
3625739 to
9861bc4
Compare
|
Not sure if I should fix the fail check for code I didn't touch ? |
OskarStark
changed the title
TranslationNodeVisitor with constant domain
| @@ -158,6 +158,19 @@ private function getReadDomainFromNode(Node $node): ?string | |||
| return $node->getAttribute('value'); | |||
| } | |||
|
|
|||
| if ( | |||
| $node instanceof FunctionExpression | |||
There was a problem hiding this comment.
Based on the updated fixture I would have expected a FilterExpression here. But that makes me think that we probably need to provide the fix for the trans tag, t() function as well as the trans filter.
There was a problem hiding this comment.
I added test and they are now supported 52b111a
|
@xabbuh Should I fix the CI ? The error (even from fabbot.io) seems unrelated to my changes, and I'm affraid about conflict during futur merge if I start fixing them... |
|
@VincentLanglet You can safely ignore things suggested by fabbot that haven't been touched by your changes. |
Thanks ; I think it's ready then :) |
nicolas-grekas
force-pushed
the
translation-twig-visitor
branch
from
b53a9be to
d14795d
Compare
|
Thank you @VincentLanglet. |
…actor (VincentLanglet) This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [Translation] Fix constant domain resolution in PhpAstExtractor | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #53356 | License | MIT Similar to #53357 Closes #53356 Commits ------- c43f6c0 [Translation] Fix constant domain resolution in PhpAstExtractor
Related to #53356 but fixing only the twig part.