Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix README link to retext-emoji #7

Merged
merged 2 commits into from
Dec 27, 2022
Merged

Fix README link to retext-emoji #7

merged 2 commits into from
Dec 27, 2022

Conversation

voxpelli
Copy link
Contributor

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Fix README link to retext-emoji as it's in a separate org from this repo

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Dec 27, 2022
Murderlon
Murderlon reviewed Dec 27, 2022
View reviewed changes
Copy link
Member

@Murderlon Murderlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for making a PR but tests are failing because of unused definition. You need to update the definition and leave the reference as it was.

[retext-emoji]: https://github.com/syntax-tree/retext-emoji

@voxpelli
Copy link
Contributor Author

@Murderlon Fixed! I rarely use that type of link myself, so I was fooled, thanks for pointing it out :)

@voxpelli voxpelli requested a review from Murderlon December 27, 2022 17:51
@Murderlon Murderlon merged commit 4bd146d into syntax-tree:main Dec 27, 2022
@github-actions

This comment has been minimized.

Sign in to view
@Murderlon Murderlon added 💪 phase/solved Post is done and removed 🤞 phase/open Post is being triaged manually labels Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remcohaszing remcohaszing remcohaszing approved these changes

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

@Murderlon Murderlon Awaiting requested review from Murderlon

Assignees
No one assigned
Labels
💪 phase/solved Post is done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@voxpelli @remcohaszing @ChristianMurphy @Murderlon