feat(shield): add support for windows host-shield #2184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francesco-furlan
force-pushed
the
feat/shield-support-for-windows
branch
2 times, most recently
from
251959f to
031a16a
Compare
francesco-furlan
force-pushed
the
feat/shield-support-for-windows
branch
from
031a16a to
ce0db6c
Compare
AlbertoBarba
requested changes
Mar 27, 2025
Comment on lines
+26
to
+41
| {{/* | ||
| Same as "shield.fullname" but for Windows | ||
| */}} | ||
| {{- define "shield.windows.fullname" -}} | ||
| {{- if .Values.fullname_override }} | ||
| {{- printf "%s-%s" "windows" .Values.fullname_override | trunc 63 | trimSuffix "-" }} | ||
| {{- else }} | ||
| {{- $name := (include "shield.name" .) }} | ||
| {{- if contains $name .Release.Name }} | ||
| {{- printf "%s-%s" "windows" .Release.Name | trunc 63 | trimSuffix "-" }} | ||
| {{- else }} | ||
| {{- printf "%s-%s-%s" "windows" .Release.Name $name | trunc 63 | trimSuffix "-" }} | ||
| {{- end }} | ||
| {{- end }} | ||
| {{- end }} | ||
|
|
There was a problem hiding this comment.
Not needed...u can simply use the shield.fullname passing host-windows.
It will also help to keep consistency between object naming<RELEASE-NAME>-<COMPONENT>
There was a problem hiding this comment.
I did it on purpose to have windows as a prefix, otherwise we could end up with the same name when release name + component is too long
There was a problem hiding this comment.
@mavimo @aroberts87 we were discussing that to keep a sort of naming standard it could make sense to have somthing like <RELEASE-NAME>-windows-<COMPONENT>. Do you agree?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Checklist
feat(agent,node-analyzer,sysdig-deploy):)