Skip to content

feat(shield): Allow configurable DNS Policy for Host Shield #2213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2025

Conversation

aroberts87
Copy link
Collaborator

What this PR does / why we need it:

SSIA

Checklist

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

@aroberts87 aroberts87 self-assigned this Apr 8, 2025
@aroberts87 aroberts87 requested a review from a team as a code owner April 8, 2025 18:21
Copy link
Contributor

@francesco-furlan francesco-furlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
just one small thing around the "default" function I recall we had issues in the past, but maybe it was related to some old helm versions that we don't support anymore

@mavimo mavimo force-pushed the aroberts/feat/smagent-9035-host-shield-dns-policy branch from 71e0111 to 8c8c80c Compare April 9, 2025 05:33
@mavimo mavimo enabled auto-merge (squash) April 9, 2025 06:04
@mavimo mavimo force-pushed the aroberts/feat/smagent-9035-host-shield-dns-policy branch from 8c8c80c to 1e5605c Compare April 9, 2025 06:04
@mavimo mavimo merged commit 919709d into main Apr 9, 2025
5 checks passed
@mavimo mavimo deleted the aroberts/feat/smagent-9035-host-shield-dns-policy branch April 9, 2025 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants