Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User profile page, Top App bar to layout #18

Merged
merged 13 commits into from
Jun 9, 2022
Merged

User profile page, Top App bar to layout #18

merged 13 commits into from
Jun 9, 2022

Conversation

djavorek
Copy link
Collaborator

@djavorek djavorek commented May 29, 2022 •
edited
Loading

Description of Changes

  • Top App Bar for navigation instead of links
    • Added Light/Dark mode switch
  • Simple profile page displaying only username and email
    • Not much to test, but added one simple test
  • Started to use app.scss to provide variables. Now our custom main color is passed into SMUI
    • Hopefully this it the right way to do it 🙄 (It works)
  • Fighting with Typescript, ESLint, Sourcemap issues ☢

djavorek added 9 commits May 24, 2022 23:11
@djavorek
Started to work on profile page
38c77ae 
Solved completely unrelated ts warnings, sourcemap issue, etc
@djavorek
AppBar with Dark mode toggle
f3ad451
@djavorek
Tweaked AppBar a bit more
9896ef3
@djavorek
Profile page done
0c4bd1d 
Styling groundwork, profile page looks shitty
@djavorek
Fixed Sourcemap issues
efd89a2 
Deleted silly vite config, updated svelte-preprocess. It was the key
@djavorek
Cleaning up
d558419
@djavorek
Adding simple profile test, formatting
27e4bb5
@djavorek
Fixing lint issues
3c29158 
Disabling ESLint for Svelte styles
@djavorek
Self-review
ee6d334
@djavorek djavorek changed the title User profile page, Top App bar to layout, User profile page, Top App bar to layout May 29, 2022
@djavorek djavorek requested a review from szattila98 May 29, 2022 10:49
@djavorek djavorek mentioned this pull request May 29, 2022
Closed
szattila98
szattila98 reviewed May 29, 2022
View reviewed changes
Copy link
Owner

@szattila98 szattila98 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work and styling, I will approve it but there is a regression with expense insert and delete and it would be nice if you could patch that up.

@szattila98 szattila98 self-requested a review May 29, 2022 14:15
szattila98
szattila98 previously approved these changes May 29, 2022
View reviewed changes
@djavorek
Fix build error (oops)
ee82a22 
Modify Svelte Github workflow to dont run checks twice on PRs
@szattila98 szattila98 self-requested a review June 9, 2022 18:09
@djavorek djavorek merged commit bac37d1 into main Jun 9, 2022
@djavorek djavorek deleted the feature/5_user_profile_page branch June 9, 2022 18:10
@djavorek djavorek mentioned this pull request Jun 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szattila98 szattila98 szattila98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djavorek @szattila98