Allow the usage of push streams #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pietermees If you could leave some feedback there, that would be great! |
szmarczak
commented
Jul 29, 2019
szmarczak
commented
Jul 29, 2019
szmarczak
commented
Jul 29, 2019
Pull Request Test Coverage Report for Build 204
💛 - Coveralls |
szmarczak
commented
Jul 29, 2019
| @@ -173,7 +178,7 @@ class Agent extends EventEmitter { | |||
| this._processQueue(name); | |||
| }); | |||
|
|
|||
| session.once('remoteSettings', () => { | |||
| session.once('localSettings', () => { | |||
There was a problem hiding this comment.
Firstly we receive a SETTINGS frame from the server, then we receive an acknowledgement of our SETTINGS frame. At this point the connection is fully estabilished, we have everything we need to know.
pietermees
reviewed
Jul 29, 2019
There was a problem hiding this comment.
@szmarczak just did a quick scan of the PR but makes sense to me and nothing stood out as a problem!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Push streams are disabled by default, but they can be enabled from now on.
Fixes #16