Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quick_xml::se::to_string returns a DeError #227

Closed
ghost opened this issue Jul 31, 2020 · 3 comments · Fixed by #810
Closed

quick_xml::se::to_string returns a DeError #227

ghost opened this issue Jul 31, 2020 · 3 comments · Fixed by #810

Comments

@ghost
Copy link

ghost commented Jul 31, 2020

Name of the error doesn't fit, I would expect it to return something like SeError.
@tafia
Copy link
Owner

tafia commented Sep 10, 2020

Yes. Mind doing a PR?

@ghost
Copy link
Author

ghost commented Sep 11, 2020

yes, I can make a PR

@dralley
Copy link
Collaborator

dralley commented Mar 30, 2021

@ozgrakkurt I can't find any PR for this, have you opened one?

@Mingun Mingun mentioned this issue Sep 28, 2024
Merged
RedPhoenixQ added a commit to RedPhoenixQ/quick-xml that referenced this issue Sep 29, 2024
@RedPhoenixQ
Split SeError from DeError
f0e17be 
This is needed for a larger change of error return values in Writer

Refs: tafia#227
@Mingun Mingun linked a pull request Sep 29, 2024 that will close this issue
Return std::io::Error from Writer methods #810
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return std::io::Error from Writer methods RedPhoenixQ/quick-xml
2 participants
@dralley @tafia