Add .rustfmt.toml, specify edition = "2021" #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisianoi
force-pushed
the
add-rustfmt-toml
branch
from
d321b19 to
d2cf665
Compare
There are two common ways to run rustfmt: $ cargo fmt $ rustfmt In the first case, Cargo.toml will be used to configure rustfmt. In the second case, Cargo.toml won't be used and rustfmt will assume certain defaults. Specifically, it will default to Rust 2015 edition which for the quick-xml project results in errors like: [E0670]: async fn is not permitted in Rust 2015 One of the scenarios when rustfmt is called instead of cargo fmt is "rustic" mode in emacs. The developers of "rustic" mode ask to configure .rustfmt.toml: See: https://github.com/brotzeit/rustic?tab=readme-ov-file#edition-2018 Add .rustfmt.toml, specify edition = "2021"
alisianoi
force-pushed
the
add-rustfmt-toml
branch
from
d2cf665 to
7d19cf1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #745 +/- ##
==========================================
- Coverage 61.24% 61.19% -0.06%
==========================================
Files 39 39
Lines 16277 16235 -42
==========================================
- Hits 9969 9935 -34
+ Misses 6308 6300 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two common ways to run rustfmt:
$ cargo fmt
$ rustfmt
In the first case, Cargo.toml will be used to configure rustfmt. In the second case, Cargo.toml won't be used and rustfmt will assume certain defaults. Specifically, it will default to Rust 2015 edition which for the quick-xml project results in errors like:
[E0670]: async fn is not permitted in Rust 2015
One of the scenarios when rustfmt is called instead of cargo fmt is "rustic" mode in emacs. The developers of "rustic" mode ask to configure .rustfmt.toml:
See: https://github.com/brotzeit/rustic?tab=readme-ov-file#edition-2018