Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use TypeScript #10

Closed
ShoshinNikita opened this issue Nov 17, 2018 · 3 comments
Closed

Use TypeScript #10

ShoshinNikita opened this issue Nov 17, 2018 · 3 comments
Labels
enhancement New feature or request major
Milestone
v0.4

Comments

@ShoshinNikita
Copy link
Member

No description provided.

@ShoshinNikita ShoshinNikita added the enhancement New feature or request label Nov 17, 2018
@ShoshinNikita ShoshinNikita added this to the v0.4 milestone Dec 3, 2018
ShoshinNikita added a commit that referenced this issue Dec 5, 2018
@ShoshinNikita
Replace global/index.js with global/index.ts #10
865bd6d
ShoshinNikita added a commit that referenced this issue Dec 5, 2018
@ShoshinNikita
Add tools.ts #10
0476893 
It has useful functions (isErrorStatusCode, logError, logInfo).
It also exports Const object
ShoshinNikita added a commit that referenced this issue Dec 5, 2018
@ShoshinNikita
Update Event Bus #10
ff52210
ShoshinNikita added a commit that referenced this issue Dec 5, 2018
@ShoshinNikita
Update Store #10
61197a7
ShoshinNikita added a commit that referenced this issue Dec 5, 2018
@ShoshinNikita
Update State #10
d880d7e
ShoshinNikita added a commit that referenced this issue Dec 5, 2018
@ShoshinNikita
Replace index/index.js with index/index.ts #10
f105ae5
ShoshinNikita added a commit that referenced this issue Dec 5, 2018
@ShoshinNikita
Update Top Bar #10
4deb485 
We need to replace vue-clickaway2 because it doesn't support TS
ShoshinNikita added a commit that referenced this issue Dec 5, 2018
@ShoshinNikita
Replace vue-clickaway2 with custom event listener #10
b0ac5f7
ShoshinNikita added a commit that referenced this issue Dec 5, 2018
@ShoshinNikita
Set parser to "typescript" in .prettierrc.json #10
f2e2a64
ShoshinNikita added a commit that referenced this issue Dec 5, 2018
@ShoshinNikita
Small fixes #10
afd7250 
Move vue.shims.d.ts to src/.
Format src/global/index.ts
ShoshinNikita added a commit that referenced this issue Dec 5, 2018
@ShoshinNikita
Move Tag, File classes into index/global.ts #10
d00e3bb
ShoshinNikita added a commit that referenced this issue Dec 5, 2018
@ShoshinNikita
Update Tag component #10
2ee3217
ShoshinNikita added a commit that referenced this issue Dec 5, 2018
@ShoshinNikita
Update RenderTagsInput component #10
c68937e
ShoshinNikita added a commit that referenced this issue Dec 5, 2018
@ShoshinNikita
Update File class #10
a0a7660
ShoshinNikita added a commit that referenced this issue Dec 5, 2018
@ShoshinNikita
Fix bug when tags are undefined #10
dc28ac5 
We have to wait for tags are loaded
ShoshinNikita added a commit that referenced this issue Dec 5, 2018
@ShoshinNikita
Update Files Block #10
f14219d
ShoshinNikita added a commit that referenced this issue Dec 5, 2018
@ShoshinNikita
Fix sort buttons #10
9e61ec0
ShoshinNikita added a commit that referenced this issue Dec 5, 2018
@ShoshinNikita
Remove calling parent methods in Files.vue #10
91b9a73
ShoshinNikita added a commit that referenced this issue Dec 5, 2018
@ShoshinNikita
Update Events structure #10
197927e
ShoshinNikita added a commit that referenced this issue Dec 5, 2018
@ShoshinNikita
Move Files.vue into Files folder #10
4b74f0a
ShoshinNikita added a commit that referenced this issue Dec 5, 2018
@ShoshinNikita
Update Upload Block #10
29642c2
ShoshinNikita added a commit that referenced this issue Dec 6, 2018
@ShoshinNikita
Replace mounted with created #10
1d2aff6
ShoshinNikita added a commit that referenced this issue Dec 6, 2018
@ShoshinNikita
Change workflow of UpdateSelectedFiles event #10
6784b6c 
1) $emit event
2) FilesBlock calls updateSelectedFiles()
3) Set selectedFilesCounter = $children.length
4) $emit "getFile" event to every child
5) Children use $parent.$emit("sendFile")
6) Process a response and reduce selectedFilesCounter
7) Update selectedFiles in SharedStore, when selectedFilesCounter == 0
8) SharedStore sets selectedFilesReady to true (default - false)
ShoshinNikita added a commit that referenced this issue Dec 6, 2018
@ShoshinNikita
Update Context menu #10
04eae3a
ShoshinNikita added a commit that referenced this issue Dec 6, 2018
@ShoshinNikita
Add objectToFile function into Store #10
416d411
ShoshinNikita added a commit that referenced this issue Dec 6, 2018
@ShoshinNikita
Update Preview Window #10
f38b8dc
ShoshinNikita added a commit that referenced this issue Dec 7, 2018
@ShoshinNikita
Update Log Window #10
2e2e7be
ShoshinNikita added a commit that referenced this issue Dec 13, 2018
@ShoshinNikita
Separate Modal Window to several Vue components #10. Resolve #14
8bb8799 
There are many bugs. But it compiles.
ShoshinNikita added a commit that referenced this issue Dec 13, 2018
@ShoshinNikita
Fix Files.vue #10
19fa132 
Fix reference to SharedState
@ShoshinNikita
Copy link
Member Author

Modal Window for single files works. But there're problems with select mode

ShoshinNikita added a commit that referenced this issue Dec 13, 2018
@ShoshinNikita
Update Modal Window #10
bb90344
ShoshinNikita added a commit that referenced this issue Dec 13, 2018
@ShoshinNikita
Fix Select Add and Delete Tags Windows #10
4a48c48
ShoshinNikita added a commit that referenced this issue Dec 13, 2018
@ShoshinNikita
Add ModalWindow.HideWindow Event #10
f7b6b98 
Remove <string> in Events object
ShoshinNikita added a commit that referenced this issue Dec 13, 2018
@ShoshinNikita
Update Modifying Tags component #10
5263395
ShoshinNikita added a commit that referenced this issue Dec 13, 2018
@ShoshinNikita
Fix bug in RenderTagsInput.vue #10
11dd00f
ShoshinNikita added a commit that referenced this issue Dec 13, 2018
@ShoshinNikita
Store.allFiles and Store.allTags are reactive now #10
ae68b13 
Solution: github.com/vuejs/vue/issues/2410#issuecomment-318487855
ShoshinNikita added a commit that referenced this issue Dec 13, 2018
@ShoshinNikita
Update src/login/LoginForm.vue #10
84f8e18
@ShoshinNikita
Copy link
Member Author

ShoshinNikita commented Dec 13, 2018 •
edited
Loading

It is done. What's left is to test it for bugs

ShoshinNikita added a commit that referenced this issue Dec 15, 2018
@ShoshinNikita
Move Const into const.ts #10
f9a9cbd
ShoshinNikita added a commit that referenced this issue Dec 15, 2018
@ShoshinNikita
Update imports #10
b4783a3 
* Change import paths: add aliases "@app", "@components"
* Sort imports
ShoshinNikita added a commit that referenced this issue Dec 15, 2018
@ShoshinNikita
Change extension of src/login/login.js to .ts #10
2250aed
@ShoshinNikita
Copy link
Member Author

Close with #21. All left bugs will be fixed in master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request major
Projects
None yet
Milestone
v0.4
Development

No branches or pull requests
1 participant
@ShoshinNikita