Fix extension mocking during tests #3773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed testing setup of `jest-webextension-mock` and, removed the custom `webextension-polyfill` mock as it was no longer necessary. Missing methods not supplied by `jest-webextension-mock` are initialized during setup through `setup-extension-mock.ts`. Also fixed an `await` omission in a test...
Logging was just adding noise to the summary of the test run
Random hash cannot be used as a valid eth address
Shadowfiend
reviewed
Feb 13, 2025
| @@ -11,7 +11,7 @@ const IS_CI = process.env.CI === "true" | |||
| // CI workflows to get an overview of both failed expectations and possible errors. | |||
| // This is not the case during development, hence, we set the minimum log level to warning | |||
| // as it helps with debugging while writing new tests. | |||
| logger.logLevel = IS_CI ? LogLevel.error : LogLevel.warn | |||
| logger.logLevel = IS_CI ? LogLevel.off : LogLevel.warn | |||
There was a problem hiding this comment.
Do we not want error logs?
There was a problem hiding this comment.
Yes, but I removed it because jest already points at where a test failed
Shadowfiend
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed testing setup of
jest-webextension-mockand, removed the customwebextension-polyfillmock as it was no longer necessary.Missing methods not supplied by
jest-webextension-mockare initialized during setup throughsetup-extension-mock.ts. Also fixed anawaitomission in a test...Latest build: extension-builds-3773 (as of Thu, 06 Feb 2025 00:21:17 GMT).