Fix excessive loading time on new accounts #3788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a case where a balance of zero would prevent loading from finishing early and, reduces initialLoad timer to 90 seconds.
Shadowfiend
reviewed
Feb 25, 2025
| @@ -264,7 +264,7 @@ export const selectAccountAndTimestampedActivities = createSelector( | |||
| return { | |||
| combinedData: { | |||
| assets: combinedAssetAmounts, | |||
| totalMainCurrencyValue: totalMainCurrencyAmount | |||
| totalMainCurrencyValue: isDefined(totalMainCurrencyAmount) | |||
There was a problem hiding this comment.
Super sneaky coercion bug, maybe we can catch more of these with something like https://typescript-eslint.io/rules/strict-boolean-expressions/
Shadowfiend
reviewed
Feb 25, 2025
| @@ -376,7 +376,7 @@ export default class ReduxService extends BaseService<never> { | |||
| ) { | |||
| super({ | |||
| initialLoadWaitExpired: { | |||
| schedule: { delayInMinutes: 2.5 }, | |||
| schedule: { delayInMinutes: 1.5 }, | |||
Shadowfiend
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a case where a balance of zero would prevent loading from finishing early and reduces the
initialLoadtimer to 90 seconds.To Test
Latest build: extension-builds-3788 (as of Tue, 25 Feb 2025 22:48:46 GMT).