Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Campaign NFTs on Wallet UI #3804

Merged
merged 4 commits into from
Mar 14, 2025
Merged

Display Campaign NFTs on Wallet UI #3804

merged 4 commits into from
Mar 14, 2025

Conversation

hyphenized
Copy link
Collaborator

@hyphenized hyphenized commented Mar 13, 2025

Aggregates campaign NFT contract data to the NFT list

Latest build: extension-builds-3804 (as of Fri, 14 Mar 2025 19:27:29 GMT).

Removes a collection from state if NFT count is defined and is zero
@hyphenized hyphenized requested a review from Shadowfiend March 13, 2025 10:52
@hyphenized hyphenized self-assigned this Mar 13, 2025
Base automatically changed from campaign-1 to main March 14, 2025 18:18
Copy link
Contributor

@Shadowfiend Shadowfiend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to go ahead and land this so we have a consolidated main. We can always do bug fixes in additional PRs.

if (campaignChains.length) {
collections.push({
id: NFT_COLLECTION_ID,
name: "TahoXMezo",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this… Have spaces by any chance? <_<

} from "./constants"
import { EVMNetwork } from "./networks"
// Networks that are not added to this struct will
// not have an in-wallet NFT tab
export const CHAIN_ID_TO_NFT_METADATA_PROVIDER: {
[chainID: string]: ("simplehash" | "poap")[]
[chainID: string]: ("simplehash" | "poap" | "campaign")[]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@Shadowfiend Shadowfiend enabled auto-merge March 14, 2025 19:19
@Shadowfiend Shadowfiend merged commit 6502f82 into main Mar 14, 2025
6 checks passed
@Shadowfiend Shadowfiend deleted the campaign-nft branch March 14, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants