Resolve campaign settings remotely #3805
Open
+106
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements in memory storage to override certain build time parameters This can be used to flip a feature flag without having to make a new release
Shadowfiend
reviewed
Mar 14, 2025
| } as const | ||
|
|
||
| type BuildTimeFlagType = keyof typeof BuildTimeFlag | ||
|
|
||
| export type RuntimeFlagType = keyof typeof RuntimeFlag | ||
|
|
||
| export type FeatureFlagType = RuntimeFlagType | BuildTimeFlagType | ||
| export type FeatureFlagType = | ||
| | RuntimeFlagType |
There was a problem hiding this comment.
Isn't this roughly the same as the dynamic one?
There was a problem hiding this comment.
Yeah I think restoring all the runtime flag code paths and then hooking them up to your lookup stuff is going to achieve what we're trying to do here... But I might be misremembering.
There was a problem hiding this comment.
Hold on I think I got carried away with the types lol. We only need to check === "true" for boolean flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements in memory storage to override certain build time parameters. This can be used to e.g. flip a feature flag without having to make a new release. Since campaign settings are only checked during browser startup, user will need to perform another browser restart before the feature is flipped.
Testing
Latest build: extension-builds-3805 (as of Fri, 14 Mar 2025 20:33:46 GMT).