Update/modernize the Bazel build tooling. (google#474)

This includes:

- Adding a .bazelignore so building `...` doesn't try to build the node_modules directory.
- Removing a bazelrc flag that no longer exists and isn't needed anymore.
- Switching to a modern rollup_bundle implementation. This requires:
  - Adding a config file to set the global name and license banner.
  - Generating output formats separately, since it no longer generates all of them.
  - Using the Rollup Buble plugin to downlevel (transpile) to ES5.
- Switching npm_package to the modern pkg_npm.
  - This cleans up some "replacements" (formerly called "substitutions")
- Switching from `bazel` to `bazelisk` as `bazel` is now [deprecated](https://www.npmjs.com/package/@bazel/bazel) for this use case.
- Upgrading to rules_nodejs version 4.6.0.
- Switching `ts_web_test` to the modern `karma_web_test` (which is in the `@bazel/concatjs` package).

The JS output is roughly the same. There are some small changes related to variable renaming and optimizations that shouldn't affect runtime behavior. The main difference is that the const `DEBUG` replacements now work (before the `DEBUG` const got inlined before the replacement step).

Author: emspishak

Diff for: .bazelignore

@@ -0,0 +1 @@
+node_modules

Diff for: .bazelrc

@@ -36,12 +36,6 @@ test --nolegacy_external_runfiles
 # Prevent TypeScript worker seeing files not declared as inputs
 build --worker_sandboxing
 
-# Turn on the "Managed Directories" feature.
-# This allows Bazel to share the same node_modules directory with other tools
-# NB: this option was introduced in Bazel 0.26
-# See https://docs.bazel.build/versions/master/command-line-reference.html#flag--experimental_allow_incremental_repository_updates
-common --experimental_allow_incremental_repository_updates
-
 # Turn on --incompatible_strict_action_env which was on by default
 # in Bazel 0.21.0 but turned off again in 0.22.0. Follow
 # https://github.com/bazelbuild/bazel/issues/7026 for more details.
@@ -60,10 +54,6 @@ run --incompatible_strict_action_env
 # rather than user.bazelrc as suggested in the Bazel docs)
 try-import %workspace%/.bazelrc.user
 
-# Turn on managed directories feature in Bazel
-# This allows us to avoid installing a second copy of node_modules
-common --experimental_allow_incremental_repository_updates
-
 # Prevent TS worker from trying to expand the `includes` section in tsconfig.json.
 # It would find the "test/*.ts" reference when compiling //src:src, and the FileCache will then error
 # when TS attempts to read one of these files that doesn't belong in the compilation.

Diff for: BUILD

@@ -1,58 +1,70 @@
 package(default_visibility = ["//:__subpackages__"])
 
-load("@npm_bazel_typescript//:defs.bzl", "ts_devserver", "ts_library")
-load("@build_bazel_rules_nodejs//:defs.bzl", "npm_package")
-load("@build_bazel_rules_nodejs//:defs.bzl", "rollup_bundle")
+load("@npm//@bazel/typescript:index.bzl", "ts_library")
+load("@build_bazel_rules_nodejs//:index.bzl", "pkg_npm")
+load("@npm//@bazel/rollup:index.bzl", "rollup_bundle")
 
 ### Produce umd and cjs bundles
 
 ts_library(
     name = "dev",
     srcs = ["index.ts"],
-    deps = ["//src"],
     tsickle_typed = True,
+    deps = ["//src"],
 )
 
-rollup_bundle(
-  name = "bundle",
-  entry_point = ":index.ts",
-  deps = [":dev"],
-  global_name = "IncrementalDOM",
-  license_banner = "conf/license_header.txt",
-)
+[
+    rollup_bundle(
+        name = "bundle.%s" % format,
+        args = args,
+        config_file = "rollup.config.js",
+        entry_point = ":index.ts",
+        format = format,
+        sourcemap = "true",
+        deps = [
+            ":dev",
+            "@npm//@rollup/plugin-buble",
+        ],
+    )
+    for format, args in {
+        "cjs": [],
+        "umd": [
+            # Downlevel (transpile) to ES5.
+            "-p",
+            "@rollup/plugin-buble",
+        ],
+    }.items()
+]
 
 genrule(
-  name = "incremental-dom",
-  srcs = [":bundle.es5umd.js"],
-  outs = ["dist/incremental-dom.js"],
-  cmd = "cp $(locations :bundle.es5umd.js) $@",
+    name = "incremental-dom",
+    srcs = [":bundle.umd.js"],
+    outs = ["dist/incremental-dom.js"],
+    cmd = "cp $(locations :bundle.umd.js) $@",
 )
 
-npm_package(
-  name = "npm-umd",
-  deps = [
-      ":incremental-dom",
-  ],
-  replacements = {
-    "DEBUG" : "true"
-  }
+pkg_npm(
+    name = "npm-umd",
+    deps = [
+        ":incremental-dom",
+    ],
 )
- 
+
 genrule(
-  name = "incremental-dom-cjs",
-  srcs = [":bundle.cjs.js"],
-  outs = ["dist/incremental-dom-cjs.js"],
-  cmd = "cp $(locations :bundle.cjs.js) $@",
+    name = "incremental-dom-cjs",
+    srcs = [":bundle.cjs.js"],
+    outs = ["dist/incremental-dom-cjs.js"],
+    cmd = "cp $(locations :bundle.cjs.js) $@",
 )
 
-npm_package(
-  name = "npm-cjs",
-  deps = [
-    ":incremental-dom-cjs",
-  ],
-  replacements = {
-    "DEBUG" : "process.env.NODE_ENV != \"production\""
-  }
+pkg_npm(
+    name = "npm-cjs",
+    substitutions = {
+        "const DEBUG = true;": "const DEBUG = process.env.NODE_ENV != \"production\";",
+    },
+    deps = [
+        ":incremental-dom-cjs",
+    ],
 )
 
 ### Produce minified bundle
@@ -69,44 +81,57 @@ genrule(
 ts_library(
     name = "release",
     srcs = [":release_index"],
-    deps = ["//release"],
     tsickle_typed = True,
+    deps = ["//release"],
 )
 
 rollup_bundle(
-  name = "min-bundle",
-  entry_point = ":release_index.ts",
-  deps = [":release"],
-  global_name = "IncrementalDOM",
-  license_banner = "conf/license_header.txt",
+    name = "min-bundle",
+    args = [
+        # Downlevel (transpile) to ES5.
+        "-p",
+        "@rollup/plugin-buble",
+    ],
+    config_file = "rollup.config.js",
+    entry_point = ":release_index.ts",
+    format = "umd",
+    deps = [
+        ":release",
+        "@npm//@rollup/plugin-buble",
+    ],
 )
 
 ## Need to run uglify to minify instead of using .min.es5umd.js, since it uses
 ## Terser, which has some performance issues with the output in how it inlines
 ## functions.
 genrule(
-  name = "incremental-dom-min",
-  srcs = [":min-bundle.es5umd.js"],
-  outs = ["dist/incremental-dom-min.js"],
-  cmd = "$(location node_modules/.bin/uglifyjs) --comments --source-map=url -m -o $@ $(location min-bundle.es5umd.js)",
-  tools = ["node_modules/.bin/uglifyjs"],
+    name = "incremental-dom-min",
+    srcs = [":min-bundle.js"],
+    outs = ["dist/incremental-dom-min.js"],
+    cmd = "$(location node_modules/.bin/uglifyjs) --comments --source-map=url -m -o $@ $(location min-bundle.js)",
+    tools = ["node_modules/.bin/uglifyjs"],
 )
 
-npm_package(
-  name = "npm-min",
-  deps = [
-    ":incremental-dom-min",
-  ],
+pkg_npm(
+    name = "npm-min",
+    deps = [
+        ":incremental-dom-min",
+    ],
 )
 
 ### Emit TS files
 
-npm_package(
-  name = "npm",
-  srcs = ["package.json", "index.ts", "//src:all_files"],
-  packages = [
-    ":npm-min",
-    ":npm-umd",
-    ":npm-cjs",
-  ]
+pkg_npm(
+    name = "npm",
+    package_name = "incremental-dom",
+    srcs = [
+        "index.ts",
+        "package.json",
+        "//src:all_files",
+    ],
+    nested_packages = [
+        ":npm-cjs",
+        ":npm-min",
+        ":npm-umd",
+    ],
 )

Diff for: README.md

@@ -91,25 +91,25 @@ npm i
 To run once:
 
 ```sh
-./node_modules/.bin/bazel test ...
+./node_modules/.bin/bazelisk test ...
 ```
 
 To run on change:
 
 ```sh
-./node_modules/.bin/ibazel run ...
+./node_modules/.bin/ibazel run //test:unit_tests
 ```
 
 ### Building
 
 To build once:
 
 ```sh
-./node_modules/.bin/bazel build ...
+./node_modules/.bin/bazelisk build ...
 ```
 
 To build on change:
 
 ```sh
-./node_modules/.bin/ibazel ...
+./node_modules/.bin/ibazel build ...
 ```

Diff for: WORKSPACE

@@ -8,14 +8,16 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
 # Fetch rules_nodejs so we can install our npm dependencies
 http_archive(
     name = "build_bazel_rules_nodejs",
-    patch_args = ["-p1"],
-    patches = ["//:rules_nodejs_pr915.patch"],
-    sha256 = "3b0116a8a91a75678a57ba676c246ac0fa9c90dc3d46daef305b11b54ed4467e",
-    urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/0.33.1/rules_nodejs-0.33.1.tar.gz"],
+    sha256 = "ddb78717b802f8dd5d4c01c340ecdc007c8ced5c1df7db421d0df3d642ea0580",
+    urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/4.6.0/rules_nodejs-4.6.0.tar.gz"],
 )
 
+load("@build_bazel_rules_nodejs//:index.bzl", "node_repositories")
+
+node_repositories(package_json = ["//:package.json"])
+
 # Check the bazel version and download npm dependencies
-load("@build_bazel_rules_nodejs//:defs.bzl", "check_bazel_version", "npm_install")
+load("@build_bazel_rules_nodejs//:index.bzl", "check_bazel_version", "npm_install")
 
 # Bazel version must be at least v0.21.0 because:
 #   - 0.21.0 Using --incompatible_strict_action_env flag fixes cache when running `yarn bazel`
@@ -37,25 +39,20 @@ npm_install(
     package_lock_json = "//:package-lock.json",
 )
 
-# Install all bazel dependencies of our npm packages
-load("@npm//:install_bazel_dependencies.bzl", "install_bazel_dependencies")
-
-install_bazel_dependencies()
-
-# Setup the rules_typescript tooolchain
-load("@npm_bazel_typescript//:defs.bzl", "ts_setup_workspace")
-
-ts_setup_workspace()
-
-# Fetch transitive Bazel dependencies of npm_bazel_karma 
-load("@npm_bazel_karma//:package.bzl", "rules_karma_dependencies")
-
-rules_karma_dependencies()
+http_archive(
+    name = "io_bazel_rules_webtesting",
+    sha256 = "e9abb7658b6a129740c0b3ef6f5a2370864e102a5ba5ffca2cea565829ed825a",
+    urls = ["https://github.com/bazelbuild/rules_webtesting/releases/download/0.3.5/rules_webtesting.tar.gz"],
+)
 
-# Setup web testing, choose browsers we can test on 
+# Set up web testing, choose browsers we can test on
 load("@io_bazel_rules_webtesting//web:repositories.bzl", "web_test_repositories")
- 
+
 web_test_repositories()
 
-load("@npm_bazel_karma//:browser_repositories.bzl", "browser_repositories")
-browser_repositories()
+load("@io_bazel_rules_webtesting//web/versioned:browsers-0.3.3.bzl", "browser_repositories")
+
+browser_repositories(
+    chromium = True,
+    firefox = True,
+)