Fix notification webhook flow #1051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nasir-rabbani
commented
Oct 8, 2021
nasir-rabbani
commented
- Added Terrascan errors in Notification web-hook data
- now terrascan do not error out even if web hook responds with non 2xx status codes
nasir-rabbani
requested review from
patilpankaj212,
kanchwala-yusuf and
Rchanger
nasir-rabbani
force-pushed
the
fix-notification-webhook-flow
branch
from
dd40c1f to
bf6a1f3
Compare
Codecov Report
@@ Coverage Diff @@
## master #1051 +/- ##
==========================================
- Coverage 78.57% 78.56% -0.01%
==========================================
Files 238 238
Lines 6477 6476 -1
==========================================
- Hits 5089 5088 -1
Misses 1075 1075
Partials 313 313
|
kanchwala-yusuf
previously approved these changes
Oct 14, 2021
nasir-rabbani
changed the title
nasir-rabbani
force-pushed
the
fix-notification-webhook-flow
branch
from
bf6a1f3 to
616f417
Compare
cesar-rodriguez
changed the title
nasir-rabbani
force-pushed
the
fix-notification-webhook-flow
branch
from
616f417 to
8251b78
Compare
nasir-rabbani
force-pushed
the
fix-notification-webhook-flow
branch
from
8251b78 to
6af3a2f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
kanchwala-yusuf
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.