-
Notifications
You must be signed in to change notification settings - Fork 518
Use Docker buildx for multi-platform support #1062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@cesar-rodriguez hopefully this tiny commit should be enough to build a multi platform image |
Codecov Report
@@ Coverage Diff @@
## master #1062 +/- ##
=======================================
Coverage 77.73% 77.73%
=======================================
Files 272 272
Lines 7683 7683
=======================================
Hits 5972 5972
Misses 1357 1357
Partials 354 354 |
@rnsc I modified the workflow so we can test that this works before merging, but there seems to be an issue with the driver: https://github.com/accurics/terrascan/pull/1062/checks?check_run_id=3952337701 |
Hey @cesar-rodriguez thank you for this! I'll have a deeper look to see if I'm missing anything. |
Kudos, SonarCloud Quality Gate passed! |
@cesar-rodriguez I've also noticed that there's an "amd64" value set in the Dockerfile, I'll need to investigate that too, not as trivial of a change as I thought! |
Kudos, SonarCloud Quality Gate passed!
|
This PR should solve #1061.
Hopefully this can be built within your current pipeline (referring to my first commit).