Feature/ec2 cog lambda acm cft #1129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ec2 instance - cognito user pool - lambda function - acm certificate
1. acm certificate 2. cognito user pool 3. instance, network interface 4. lambda function
gaurav-gogia
requested review from
cesar-rodriguez,
patilpankaj212 and
kanchwala-yusuf
Codecov Report
@@ Coverage Diff @@
## master #1129 +/- ##
==========================================
+ Coverage 78.77% 79.09% +0.31%
==========================================
Files 244 248 +4
Lines 6800 6907 +107
==========================================
+ Hits 5357 5463 +106
Misses 1113 1113
- Partials 330 331 +1
|
|
Kudos, SonarCloud Quality Gate passed!
|
patilpankaj212
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for following resources:
Updated signature of function
mapConfigForResourceto account for edge cases where resources may require their names to generate IDs while generating configurations